Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Keyboard shortcut for "Preview file" quick action working only when the title of the thumbnail is focused. #14420

Closed
thupsi opened this issue Feb 17, 2024 · 6 comments
Labels

Comments

@thupsi
Copy link

thupsi commented Feb 17, 2024

What happened?

On the relase notes for Craft 5 there is the following item:

Selected assets within Assets fields no longer open the file preview modal when their thumbnail is clicked on. The “Preview file” quick action, or the Shift + Spacebar keyboard shortcut, can be used instead.

Having selected a thumb, I tried to use the shortcut to no avail and initialy I thought it wasn't working at all. Upon further investigation I realised that the thumbnail's title must be focused for the shortcut to take effect.

Is this intentional? I does feel awkward.

Craft CMS version

5.0.0-beta.2

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@thupsi thupsi added the bug label Feb 17, 2024
@brandonkelly
Copy link
Member

Thanks for reporting that! Turns out the Shift + Spacebar keyboard shortcut hasn’t been working quite right for a while, even back in Craft 3. Now fixed for the next 3/4/5 releases. (2e9c4ac)

@thupsi
Copy link
Author

thupsi commented Feb 23, 2024

@brandonkelly The shortcut still doesn't work in Craft 5:

  • Select an image thumbnail in an asset field by cliking on it. The thumbnail is focused.
  • Press Shift + Spacebar. Nothing happens.
  • Press tab. The thumbnail's title is focused.
  • Press Shift + Spacebar. The preview opens.

brandonkelly added a commit that referenced this issue Feb 26, 2024
@brandonkelly
Copy link
Member

Sorry, I was only testing with keyboard navigation. Fixed now for the next release.

@thupsi
Copy link
Author

thupsi commented Feb 26, 2024

Works perfectly now, thanks!

@brandonkelly
Copy link
Member

5.0.0-beta.4 is out now with that fix. Thanks again!

@carlcs
Copy link
Contributor

carlcs commented May 6, 2024

@brandonkelly Is this also intended to work on the assets index page? Additionally, I'd like to make a feature request to allow keyboard navigation to the next/previous asset, similar to how you can do with Quicklook on a Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants