Element index "sort updated" message via live region #12286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t attribute/direction is changed
gcamacho079
commented
Nov 9, 2022
brandonkelly
requested changes
Jan 7, 2023
# Conflicts: # composer.lock # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
…t calling _updateScreenReaderStatus immediately after update
gcamacho079
requested review from
benjamindavid and
nfourtythree
as code owners
|
@brandonkelly I've made the requested change 👍🏼 |
… message on pagination change
…nd pagination text not working)
…ch/filter/pagination criteria and source change instead
gcamacho079
commented
Jan 27, 2023
# Conflicts: # src/templates/_layouts/elementindex.twig # src/web/assets/cp/CpAsset.php # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/src/js/BaseElementIndex.js # src/web/assets/craftsupport/dist/css/CraftSupportWidget.css.map # src/web/assets/dashboard/dist/css/Dashboard.css.map # src/web/assets/edittransform/dist/css/transforms.css.map # src/web/assets/edituser/dist/css/AccountSettingsForm.css.map # src/web/assets/edituser/dist/css/profile.css.map # src/web/assets/generalsettings/dist/css/rebrand.css.map # src/web/assets/graphiql/dist/css/graphiql.css.map # src/web/assets/installer/dist/css/install.css.map # src/web/assets/login/dist/css/login.css.map # src/web/assets/money/dist/css/Money.css.map # src/web/assets/plugins/dist/css/PluginManager.css.map # src/web/assets/pluginstore/dist/css/app.css.map # src/web/assets/pluginstore/dist/js/app.js # src/web/assets/pluginstore/dist/js/app.js.map # src/web/assets/pluginstoreoauth/dist/css/PluginStoreOauthCallback.css.map # src/web/assets/routes/dist/css/routes.css.map # src/web/assets/systemmessages/dist/css/system_messages.css.map # src/web/assets/updater/dist/css/Updater.css.map # src/web/assets/updates/dist/css/UpdatesUtility.css.map # src/web/assets/upgrade/dist/css/UpgradeUtility.css.map # src/web/assets/userpermissions/dist/css/UserPermissions.css.map # src/web/assets/utilities/dist/css/utilities.css.map
brandonkelly
added a commit
that referenced
this pull request
Feb 13, 2023
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aims to fix an issue where every update of the index page (source change, new page, etc.) triggered the live region message. In addition, only the table view was triggering this message, leaving changes in the Asset thumbnail view unannounced.
Functionality has been moved to
BaseElementIndexinstead.Related issues
Resolves DEV-411, DEV-1057