Feature/dev 1159 improve structure events #13429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EVENT_BEFORE_INSERT_ELEMENT
andEVENT_AFTER_INSERT_ELEMENT
events tocraft\services\Structures
craft\events\MoveElementEvent::$targetElementId
andgetTargetElement()
, for getting the target element that the action is being performed in reference to, if any. (These will benull
if$element
is being prepended/appended to the root of the structure.)craft\events\MoveElementEvent::$action
, which will be set tocraft\services\Structures::ACTION_PREPEND
,ACTION_APPEND
,ACTION_PLACE_BEFORE
, orACTION_PLACE_AFTER
.craft\events\Structures::EVENT_BEFORE_MOVE_ELEMENT
is now cancellable, so setting$isValid
tofalse
will prevent the element from getting moved.craft\base\Element::beforeMoveInStructure()
andafterMoveInStructure()
, as well as theEVENT_BEFORE_MOVE_IN_STRUCTURE
andEVENT_AFTER_MOVE_IN_STRUCTURE
events they trigger, as they were named consistently withcraft\services\Structures::EVENT_BEFORE_MOVE_ELEMENT
andEVENT_AFTER_MOVE_ELEMENT
, however they didn’t behave the same (they were also triggered for insert operations, whereas the service events were only for actual moves).Related issues
targetElementRecord
to before/after move element in structure function and events #13409