-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cms 1234 add env var support to sites language settings #14235
Merged
brandonkelly
merged 12 commits into
5.0
from
feature/cms-1234-add-env-var-support-to-sites-language-settings
Jan 30, 2024
Merged
Feature/cms 1234 add env var support to sites language settings #14235
brandonkelly
merged 12 commits into
5.0
from
feature/cms-1234-add-env-var-support-to-sites-language-settings
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
deleted the
feature/cms-1234-add-env-var-support-to-sites-language-settings
branch
January 30, 2024 17:35
@brandonkelly I don't suppose there is any chance of this being backported to Craft v4 too is there? We're currently having to do some mad stuff to do this to sites in Craft 4! |
@johnwbaxter There’s a small chance this introduces a BC break, so I wasn’t comfortable doing it for 4.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add environment variable support to sites’ language settings and the user locale settings.
It's still a work in progress.Related issues
cms-1234