Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cms 1234 add env var support to sites language settings #14235

Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jan 29, 2024

Description

Add environment variable support to sites’ language settings and the user locale settings.

It's still a work in progress.

Related issues

cms-1234

Copy link

linear bot commented Jan 29, 2024

@i-just i-just requested a review from brandonkelly January 30, 2024 12:02
@i-just i-just marked this pull request as ready for review January 30, 2024 12:02
@brandonkelly brandonkelly merged commit bfff9cf into 5.0 Jan 30, 2024
@brandonkelly brandonkelly deleted the feature/cms-1234-add-env-var-support-to-sites-language-settings branch January 30, 2024 17:35
@johnwbaxter
Copy link

@brandonkelly I don't suppose there is any chance of this being backported to Craft v4 too is there? We're currently having to do some mad stuff to do this to sites in Craft 4!

@brandonkelly
Copy link
Member

@johnwbaxter There’s a small chance this introduces a BC break, so I wasn’t comfortable doing it for 4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants