Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve batched job progress indicator #14817

Closed
wants to merge 1 commit into from

Conversation

bencroker
Copy link
Contributor

@bencroker bencroker commented Apr 16, 2024

This PR improves the batched job progress indicator by making it work more like the base job progress indicator, meaning that the percentage and indicator will move from 0% to 100% across all batches, rather than once for each batch.

In this example, a sendout is being sent to 5 recipients with a batch size of 2 (to help demonstrate the issue).

Before:

The progress of 50% is calculated as step 1 of 2 items in the current batch.

screenshot-pvvU3pIR@2x
screenshot-IP2yqgcq@2x

After:

The progress of 80% is calculated as step 4 of 5 total items in the job.

screenshot-eV4s9A0X@2x
screenshot-AKWIGtsC@2x

Here’s a real-world example that shows how the percentage and the “step of total” being out of sync can be confusing:

320714358-3df99d17-71c7-4f47-8ffa-71828377c3ab

Source: putyourlightson/craft-campaign#464

Ideally it would be backported to 4.x too.

@bossanova808
Copy link

This is great to see - the current behaviour is very confusing (at least in this context, likely any long running, countable batch process).

brandonkelly added a commit that referenced this pull request Apr 17, 2024
@brandonkelly
Copy link
Member

Thanks!! Cherry-picked your commit into the 4.9 branch (8a131a3), and also merged that into 5.1.

@brandonkelly
Copy link
Member

4.9 and 5.1 are out now with that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants