Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't count unpublished drafts towards the total #15029

Merged
merged 4 commits into from
May 22, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented May 20, 2024

Description

When getting the total number of entries in a matrix field, don't include unpublished drafts.

Related issues

#15015

@i-just i-just requested a review from brandonkelly May 20, 2024 09:05
@brandonkelly
Copy link
Member

I don’t think there’s a good reason to include any drafts in that logic. E.g. if someone had explicitly created a draft on a nested entry from its fullscreen edit page, that shouldn’t count toward the entry count.

So just removed the drafts(null) bit and it seems to be working as expected across all view modes.

@brandonkelly brandonkelly merged commit becf942 into 5.x May 22, 2024
3 checks passed
@brandonkelly brandonkelly deleted the bugfix/15015-matrix-total-entries-count branch May 22, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants