ElementEditor-powered Live Preview #15112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes!!! 🥳 |
brianjhanson
approved these changes
May 31, 2024
There was a problem hiding this comment.
🎉 I pushed a few little changes directly to the branch, so if you mess with anymore just make sure to pull.
- Updated to logical properties
- Ensure the tab menu button shows/hides on resize
- Fixed some random JS errors I ran into while testing. They may not be totally related to these changes, but figured they were worth fixing either way.
- No longer dependent on a parent ElementEditor instance - No longer reloaded when reopened, if nothing changed in the main form - Faster initial load - Save button
…eview # Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/cp/src/js/ElementEditor.js
[ci skip]
brandonkelly
deleted the
feature/cms-704-elementeditor-powered-live-preview
branch
|
I've spent some time with the revamped live preview now, and just wanted to say that I love it - it's how I always wanted LP to work and it's going to make a huge difference in AX for authors, especially when editing more complex field layouts. Nice work 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors Live Preview to create its own dedicated ElementEditor instance, embedded within the editor pane (similar to element editor slideouts).
By doing that, Live Preview gains feature parity with element editor slideouts:
The parent editor is kept up-to-date with the LP editor’s state, and its content fields are refreshed to get the latest values when LP is closed (if anything changed).
Related issues