Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm before cancelling inline editing #15142

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jun 4, 2024

Description

Before cancelling the inline edit, check if any changes were made, and if there were, confirm that you want to discard them.

Screenshot 2024-06-04 at 15 16 05

Related issues

#15139

@i-just i-just requested a review from brandonkelly June 4, 2024 14:20
@brandonkelly brandonkelly changed the base branch from 5.x to 5.2 June 4, 2024 17:53
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
[ci skip]
@brandonkelly brandonkelly merged commit 5417670 into 5.2 Jun 4, 2024
@brandonkelly brandonkelly deleted the bugfix/15139-confirm-canceling-inline-editing branch June 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants