-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Try another way" input to use a disclosure menu #15145
Merged
brandonkelly
merged 16 commits into
5.2
from
feature/pt-1693-update-try-another-way-input-to-use-a-disclosure-menu
Jun 7, 2024
Merged
Update "Try another way" input to use a disclosure menu #15145
brandonkelly
merged 16 commits into
5.2
from
feature/pt-1693-update-try-another-way-input-to-use-a-disclosure-menu
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… btn for loading spinner announcement
…to-use-a-disclosure-menu [ci skip]
i-just
approved these changes
Jun 7, 2024
Thanks for reviewing, @brandonkelly! Just made those modifications. 🙏🏼 |
…to-use-a-disclosure-menu
@gcamacho079 Thanks!! |
[ci skip]
brandonkelly
deleted the
feature/pt-1693-update-try-another-way-input-to-use-a-disclosure-menu
branch
June 7, 2024 21:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
focus
method results in the message being surfaced to screen reader users. (See attached video for VoiceOver demo)Screen.Recording.2024-06-06.at.10.24.44.AM.mov
In the video above, selecting an option from the disclosure menu causes the menu to close, and programmatic focus is moved to the spinner; because the spinner has a visually hidden text node, “Loading“ is announced. The spinner is then hidden, and focus is moved to the new form field.
Related issues
Resolves PT-1693