Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions menu to table rows for reordering #15385

Merged
merged 16 commits into from
Jul 24, 2024

Conversation

gcamacho079
Copy link
Contributor

@gcamacho079 gcamacho079 commented Jul 18, 2024

Description

This PR introduces an action button with “Move up”/“Move down” buttons to table rows so that reordering is accessible to both keyboard and mouse users without requiring dragging movements; it also makes reordering possible on touch screens.

Related issues

@gcamacho079 gcamacho079 changed the base branch from 5.x to 5.3 July 18, 2024 22:55
@gcamacho079 gcamacho079 requested a review from brandonkelly July 18, 2024 23:41
@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Jul 18, 2024
Copy link

linear bot commented Jul 19, 2024

@gcamacho079 gcamacho079 changed the title Add actions menu to table rows for reordering (WIP) Add actions menu to table rows for reordering Jul 23, 2024
@gcamacho079 gcamacho079 marked this pull request as ready for review July 23, 2024 21:43
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
[ci skip]
@brandonkelly brandonkelly merged commit 9a46567 into 5.3 Jul 24, 2024
@brandonkelly brandonkelly deleted the feature/reorder-table-rows-mobile branch July 24, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.x]: Table entries cannot be drag/dropped to re-order on touch devices
2 participants