Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortable link types #15963

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Sortable link types #15963

merged 6 commits into from
Oct 31, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Oct 25, 2024

Description

Makes it possible to sort link types within a Link field’s settings. This then determines the order in which they appear within inputs’ type selects. The type which is set to show first is the default one.

A sortable “Allowed Link Types” setting

Related issues

Copy link

linear bot commented Oct 25, 2024

@i-just i-just requested a review from brandonkelly October 25, 2024 11:08
@i-just
Copy link
Contributor Author

i-just commented Oct 25, 2024

@brandonkelly, now that I raised this PR, I wonder if maybe it would make more sense to reuse the existing src/templates/_includes/forms/checkboxSelect.twig template instead of creating a copy that does the same but with a few additions. LMK your thoughts when you have a sec, and I can adjust!

@brandonkelly brandonkelly merged commit 115888c into 5.5 Oct 31, 2024
@brandonkelly brandonkelly deleted the feature/cms-1335-sortable-link-types branch October 31, 2024 01:13
@brandonkelly
Copy link
Member

@i-just Yep agreed it makes sense to combine with checkboxSelect. Just made that change and also improved the UI a bit so the disclosure menus are only shown for selected options.

And merged 🚀 Good work!

@brandonkelly brandonkelly changed the title Feature/cms 1335 sortable link types Sortable link types Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants