make the html lang attribute dynamic in CP #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
added a commit
that referenced
this pull request
Jul 2, 2018
watarutmnh
added a commit
to watarutmnh/cms
that referenced
this pull request
Jul 4, 2018
Fixed a bug where the `<html lang>` attribute was hard-set to `en-US` rather than the current application language. (Refer: craftcms#3053)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While my client using a browser plugin to translate the page, the content automatically translated in entry edit pages.
I found out the html lang attribute has been fixed to "en-US" and it cause the problem.
that follows the locale admin user set in their preferences page.