Update Paginator.php #4208
Closed
Update Paginator.php #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Query class doesn't seem to be used in this file, and is causing this weird intermittent error: "PHP Compile Error – yii\base\ErrorException, Cannot use yii\db\Query as Query because the name is already in use." Error happens when using {% paginate %} in Twig template.
|
Thanks for pointing that out! The class was being referenced, but only by a PHP comment, so I’ve namespace it instead. Strange that it would only intermittently cause an issue. Are you running different versions of PHP on different servers perhaps? |
|
Hi Brandon, Thanks for fixing this. The reason I said it was intermittent is because I was trying to debug it, and then it fixed by itself after I rolled back all my debugging efforts. So I guess there could be some cache thing? But I don't cache the pagination part of template though. Weird. Anyway... |
|
Hm yeah maybe an OPcache thing or something, not sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Query class doesn't seem to be used in this file, and is causing this weird intermittent error: "PHP Compile Error – yii\base\ErrorException, Cannot use yii\db\Query as Query because the name is already in use." Error happens when using {% paginate %} in Twig template.
Since this class is not really in use in this file, can you consider removing it?