Optimise Job Progress #4219
Merged
Optimise Job Progress #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current progress is never updated, resulting in the database being updated regardless of whether the value of `$this->_progress` has changed or not. Additionally, `$this->_progress` should be stored as a rounded integer to avoid updating the database more times than necessary. For example, if there are 1,000 steps then the database will be update 10 times more than necessary. ``` 1: 0% 2: 0% ... 9: 0% 10: 1% 11: 1% ... ```
|
Great catch, Ben @putyourlightson |
|
Thanks! |
brandonkelly
added a commit
that referenced
this pull request
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current progress is never updated, resulting in the database being updated regardless of whether the value of
$this->_progresshas changed or not.Additionally,
$this->_progressshould be stored as a rounded integer to avoid updating the database more times than necessary. For example, if there are 1,000 steps then the database will be update 1,000 times instead of the expected 100.