Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amends for various bare bone matrix scenarios #1452

Merged
merged 1 commit into from
May 23, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented May 23, 2024

Description

When importing into a matrix field which has an entry type that only has the title field in it and no custom fields:

  • fix the Undefined array key "fields" error
  • fix the fact that such nested entry wasn’t importing correctly

When importing into a matrix field which has an entry type that doesn’t have the title and slug, just one plain text field:

  • adjust the check from $attributeInfo to isset($fields['attributes']) (both checks do the same thing, but this one is a bit easier to follow)

Related issues

#1451

@i-just i-just requested a review from angrybrad as a code owner May 23, 2024 13:59
@angrybrad angrybrad merged commit 35d8755 into 6.x May 23, 2024
5 checks passed
@angrybrad angrybrad deleted the bugfix/1451-matrix-field-amends branch May 23, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants