Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Yii log targets and use DbTarget #1462

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Conversation

timkelty
Copy link
Contributor

Description

  • Converts the existing custom logging to a Yii Log Target with a feed-me category.
  • By default, logs will now be stored in the database (feedme_logs), as they are displayed in the CP.

Related issues

Fixes #1344

Copy link
Member

@angrybrad angrybrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the install migration with the new log table for fresh installs.

@timkelty timkelty requested a review from angrybrad June 12, 2024 19:52
@timkelty
Copy link
Contributor Author

@angrybrad should be ready:

  • added install migration
  • added logging example
  • added changelog line

@angrybrad angrybrad merged commit 6bb9a9d into 5.x Jun 12, 2024
5 checks passed
@angrybrad angrybrad deleted the feature/logs-as-log-targets branch June 12, 2024 21:40
@dgsiegel
Copy link

dgsiegel commented Aug 7, 2024

@timkelty it looks like that even with your example, logs will always be stored and read from the db. Adding the logging example will additionally log it to a file, correct?

@timkelty
Copy link
Contributor Author

timkelty commented Aug 13, 2024

@dgsiegel That's correct.

@dgsiegel
Copy link

@timkelty in that case I'd urge you to review this merge request. Feed Me is quite noisy in its default configuration, and unless you set logging to false or error, that table will grow considerably if you import lots of items (10k+) regularly (few times per day).

Additionally, the README in its current form suggests that you are able to replace the default logging mechanism (and therefore also displaying the latest log entries in the UI), which is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants