Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build with docker #157

Merged
merged 3 commits into from
Jul 28, 2021
Merged

add build with docker #157

merged 3 commits into from
Jul 28, 2021

Conversation

vaayne
Copy link
Contributor

@vaayne vaayne commented Jul 19, 2021

No description provided.

@vercel
Copy link

vercel bot commented Jul 19, 2021

@vaayne is attempting to deploy a commit to the Nobelium Gang Team on Vercel.

A member of the Team first needs to authorize it.

@stale
Copy link

stale bot commented Jul 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Not received responses for too long label Jul 26, 2021
@craigary
Copy link
Owner

Hi there, sorry for the late reply~

Unfortunately I don't know much about docker, let me test this on my machine~

@stale stale bot removed the stale Not received responses for too long label Jul 27, 2021
@craigary
Copy link
Owner

Hi, I was trying to run this on my machine, it works fine, however, I am not able to load the Gravater image on the post page.

I have no idea about docker whatsoever 🤪 would you mind to take a look?

@vaayne
Copy link
Contributor Author

vaayne commented Jul 27, 2021

Hi, @craigary please try it again, it should be fixed.

@craigary
Copy link
Owner

LGTM, merged! Since I have no idea about docker whatsoever, let me mark this as "unofficial" method~
Thank you for the PR!

@craigary craigary merged commit e74f5ff into craigary:main Jul 28, 2021
@JOduMonT
Copy link

JOduMonT commented Oct 14, 2021

@vaayne for an obscure reason, when I build the Dockerfile, the tagging doesn't work.
I tried with

  • docker build -t ${IMAGE} --build-arg NOTION_PAGE_ID .
  • docker build --tag ${IMAGE} --build-arg NOTION_PAGE_ID .
  • docker build -t nobelium --build-arg NOTION_PAGE_ID .
  • docker build --tag nobelium --build-arg NOTION_PAGE_ID .
  • docker build --tag nobelium .
  • docker build --tag nobelium:latest .
  • ...
    but it always results to none.

I found a way to rename it after the build : docker tag $(docker image ls | grep "<none>" | awk '{print $3}') nobelium:latest
but still if you could think of why I have this behaviour it would be nice.


at the end it throw an error

internal/modules/cjs/loader.js:905
  throw err;
  ^

Error: Cannot find module '/bin/bash'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

@vaayne
Copy link
Contributor Author

vaayne commented Oct 14, 2021

@JOduMonT I think it was caused by #178
For now main branch was updated, you can pull main and try again.

shep-eth pushed a commit to shep-eth/notes that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants