Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed base postgres version to 16 and added automated docker build #30

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

mawoka-myblock
Copy link
Contributor

I think the title says everything relevant.

@craigpastro
Copy link
Owner

Sorry! Somehow I missed this. I’ll try to take a look this week. Thank you!

@mawoka-myblock
Copy link
Contributor Author

Here is the link to the rocker image built by the script above:

https://github.com/mawoka-myblock/pg_uuidv7/pkgs/container/pg_uuidv7

Copy link
Owner

@craigpastro craigpastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I left one question. I also have one nitty ask: could you rename the docker-publish file to use .yaml as the extension. Sorry, it’s my pet peeve. Thank you for the contribution!

.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
@craigpastro
Copy link
Owner

Thanks again for the contribution ❤️ By the way, do you think we should add something to the readme as it is now easier to test out the extension?

@craigpastro craigpastro merged commit dec9aeb into craigpastro:main Apr 4, 2024
1 check passed
@mawoka-myblock
Copy link
Contributor Author

Yea, adding the note regarding docker is probably a good idea. Also don't forget to set the package to public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants