-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cooper&Hunter Protocol based on Gree #1508
Comments
We really like to have the "rawData" that you get with IRrecvDumpV2+. Please give full brand and model of both unit and remote. |
My hardware (esp-01) makes it difficult to have both serial console and IR receiver to be available simultaneously, but I'll try to obtain that data.
Remote: YB1F2 (Google search even shows it's Gree branded, but my has C&H logo on it) |
FYI, try the Kelvinator protocol, it is very similar to the Gree protocol, and has the 20ms gap as you're describing. |
* Based on ground-truth data & similarity to the Kelvinator protocol, I'm changing the `kGreeMsgSpace` to approx 20ms instead of 19ms. Ref: - https://github.com/crankyoldgit/IRremoteESP8266/blob/e70cd5b9a46b7a4e14f7f21e439f1b70568d50cf/test/ir_Gree_test.cpp#L609 - https://github.com/crankyoldgit/IRremoteESP8266/blob/e70cd5b9a46b7a4e14f7f21e439f1b70568d50cf/src/ir_Kelvinator.cpp#L42-L43 * Update supported model info. Fixed #1508
It is indeed similar in timings, and even works on basic level (on/off, set temps, etc). |
Thanks for that. I've added it to the supported list.
I've reviewed previous data we have, and your word on your data, and my personal experience with the Kelvinator protocol which overlaps a lot with the Gree Protocol, and it lines up. It looks like the value should be closer to 20ms (19980us) so I've created a branch with it updated: https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1508 / PR #1509 Can you please download it, try it out, & let us know how it goes? |
Yes, that works perfectly. |
Thanks for confirming. |
* Based on ground-truth data & similarity to the Kelvinator protocol, I'm changing the `kGreeMsgSpace` to approx 20ms instead of 19ms. Ref: - https://github.com/crankyoldgit/IRremoteESP8266/blob/e70cd5b9a46b7a4e14f7f21e439f1b70568d50cf/test/ir_Gree_test.cpp#L609 - https://github.com/crankyoldgit/IRremoteESP8266/blob/e70cd5b9a46b7a4e14f7f21e439f1b70568d50cf/src/ir_Kelvinator.cpp#L42-L43 * Update supported model info. Fixed #1508
_v2.7.19 (20210706)_ **[Bug Fixes]** - Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517) - PANASONIC_AC: Fix Low and High fan speeds (#1515) - Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499) - IRac: Fix off-by-one error in Coolix's sleep setting. (#1500) - Fix undefined constant (#1490) **[Features]** - Add detailed support for Kelon ACs (#1494) - Experimental basic support for Teknopoint A/C protocol (#1486 #1504) - Daikin64: Add support for Heat mode (#1492) - Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481) **[Misc]** - GREE: Update inter-message gap timing (#1508 #1509) - IRac: Change Coolix to send special messages after a normal message. (#1501 #1502) - Fix compiler warnings causing Travis failures. (#1491) - Update supported model info (#1477 #1485 #1488 #1489) - Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
* Regenerate Doxygen documentation * v2.7.19 release _v2.7.19 (20210706)_ **[Bug Fixes]** - Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517) - PANASONIC_AC: Fix Low and High fan speeds (#1515) - Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499) - IRac: Fix off-by-one error in Coolix's sleep setting. (#1500) - Fix undefined constant (#1490) **[Features]** - Add detailed support for Kelon ACs (#1494) - Experimental basic support for Teknopoint A/C protocol (#1486 #1504) - Daikin64: Add support for Heat mode (#1492) - Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481) **[Misc]** - GREE: Update inter-message gap timing (#1508 #1509) - IRac: Change Coolix to send special messages after a normal message. (#1501 #1502) - Fix compiler warnings causing Travis failures. (#1491) - Update supported model info (#1477 #1485 #1488 #1489) - Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
FYI, the committed & merged changes thus far have been included in the newly released version of the library. i.e. v2.7.19 |
Version/revision of the library used
2.7.18
Intro
The hardware is as follows:
Previous Works
As mentioned in #602, some other software had success in controlling C&H with Gree protocol, so I have tried comparing signals sent by this library on Gree protocol with what is actually sent by C&H remote, and binary protocol indeed matches.
Timings, however, are slightly different - inter-message space is 19980ms instead of 19000ms for C&H, for example.
So "as is" Gree protocol does not work
Raw Data
I've attached a dump of actual C&H remote signals in Saleae Logic format (viewable with https://www.saleae.com/downloads/, no actual hardware needed to view):
c_h-examples.zip
The Suggestion
Cooper&Hunter AC can be controlled if we replace constants in https://github.com/crankyoldgit/IRremoteESP8266/blob/master/src/ir_Gree.cpp#L22 with the following:
(most significant change is kGreeMsgSpace)
The Issue
However, I am unsure how to properly add new AC protocol to the library with proper detection, etc - so this is not a pull request, but an issue instead.
Gree protocol with the changes outlined above works perfectly for me controlling C&H air conditioner - so it may be helpful to others with similar hardware.
The text was updated successfully, but these errors were encountered: