Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite ir_Amcor by using bit field #1263

Merged
merged 1 commit into from
Sep 5, 2020
Merged

rewrite ir_Amcor by using bit field #1263

merged 1 commit into from
Sep 5, 2020

Conversation

siriuslzx
Copy link
Collaborator

No description provided.

@crankyoldgit crankyoldgit self-requested a review September 5, 2020 07:50
@crankyoldgit crankyoldgit self-assigned this Sep 5, 2020
crankyoldgit
crankyoldgit approved these changes Sep 5, 2020
View reviewed changes
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Again, thanks for doing this! It's awesome.

@crankyoldgit
Copy link
Owner

@siriuslzx I've invited you to be a Collaborator for this library. That should give you permission to "Squash & Merge" your own PRs once they've been reviewed & approved by someone (like this one).

I'll leave this one for you to merge, unless you don't want that level of access etc., but I think you deserve the credit etc.

@siriuslzx
Copy link
Collaborator Author

@siriuslzx I've invited you to be a Collaborator for this library. That should give you permission to "Squash & Merge" your own PRs once they've been reviewed & approved by someone (like this one).

I'll leave this one for you to merge, unless you don't want that level of access etc., but I think you deserve the credit etc.

Thank you. What should I do to become a Collaborator and what duties will I get?

@crankyoldgit
Copy link
Owner

Thank you. What should I do to become a Collaborator and what duties will I get?

Github should have sent you a notification. Check your email and/or the top right of web page when you log into the github page. The invite should be there I think.

Duties: Um ... You don't have to do anything. But I guess read the Library Maintainer's guide. Code reviews would be nice. I currently lean on @NiKiZe for reviewing my code. He also jumps on questions/issues while I'm asleep etc and asks basic questions to get the needed info and help out etc.

All in all it's just an extra permission you'll be granted to be able to edit the Wiki pages, merge code yourself after a code review, and to be able to review other people's code. You will be able to stop/restart/etc Travis/CI jobs as well I think. Oh, and you get a cool label next to your name when responding to an issue on this project I think.

@siriuslzx
Copy link
Collaborator Author

Thank you. What should I do to become a Collaborator and what duties will I get?

Github should have sent you a notification. Check your email and/or the top right of web page when you log into the github page. The invite should be there I think.

Duties: Um ... You don't have to do anything. But I guess read the Library Maintainer's guide. Code reviews would be nice. I currently lean on @NiKiZe for reviewing my code. He also jumps on questions/issues while I'm asleep etc and asks basic questions to get the needed info and help out etc.

All in all it's just an extra permission you'll be granted to be able to edit the Wiki pages, merge code yourself after a code review, and to be able to review other people's code. You will be able to stop/restart/etc Travis/CI jobs as well I think. Oh, and you get a cool label next to your name when responding to an issue on this project I think.

You are right, it's cool ! Sadly, I can only do limited things since my son is less than 1 year old and I only have time on weekends.

@siriuslzx siriuslzx merged commit 8323541 into crankyoldgit:master Sep 5, 2020
@crankyoldgit
Copy link
Owner

You are right, it's cool ! Sadly, I can only do limited things since my son is less than 1 year old and I only have time on weekends.

I'm not expecting much etc. As I said, you don't have to do anything. RealLife™ always take priority. Do what you can, when you can, if & when you feel like it. No one gets paid for this! ;-)

@NiKiZe
Copy link
Collaborator

NiKiZe commented Sep 5, 2020

@siriuslzx nice to have your help out whenever you have the time and will for it!

crankyoldgit added a commit that referenced this pull request Oct 2, 2020
@crankyoldgit
v2.7.11 release
786e9cd 
_v2.7.11 (20200902)_

**[Features]**
- Transcold: Add detailed support. (#1256 #1278)
- Airwell/Whirlpool: Add handling of previous state to `.toCommon()` (#1275 #1276)
- IRMQTTServer: Change how MQTT packet/buffer size is set. (#1271)
- Fujitsu: Add support for timers. (#1255 #1261 #1262)
- Neoclima: Add Economy & Fahrenheit support (#1260 #1265)
- Technibel: Cleanup and code fixes/improvements. (#1259 #1266)
- Technibel: Add detailed A/C support (#1259)
- Transcold: Add basic support. (#1256 #1258)

**[Misc]**
- refactor ir_Delonghi (#1285)
- Whirlpool: Change default mode in `convertMode()` (#1283 #1284)
- SamsungAC: Unit tests to help debug poor signal (#1277 #1280)
- Add question & note about VS1838b use to issue template. (#1281)
- rewrite ir_Corona (#1274)
- tools/mkkeywords: Fix minor parsing issue. (#1272)
- Add Zhongxian Li to Contributers.md (#1270)
- rewrite Carrier (#1269)
- rewrite ir_Argo by using bit field (#1264)
- rewrite ir_Amcor by using bit field (#1263)
- Update Fujitsu supported model info.
- Clarify the scope of the LittleFS breaking change.
crankyoldgit added a commit that referenced this pull request Oct 2, 2020
@crankyoldgit
v2.7.11 release
a8cc14b 
_v2.7.11 (20201002)_

**[Features]**
- Transcold: Add detailed support. (#1256 #1278)
- Airwell/Whirlpool: Add handling of previous state to `.toCommon()` (#1275 #1276)
- IRMQTTServer: Change how MQTT packet/buffer size is set. (#1271)
- Fujitsu: Add support for timers. (#1255 #1261 #1262)
- Neoclima: Add Economy & Fahrenheit support (#1260 #1265)
- Technibel: Cleanup and code fixes/improvements. (#1259 #1266)
- Technibel: Add detailed A/C support (#1259)
- Transcold: Add basic support. (#1256 #1258)

**[Misc]**
- refactor ir_Delonghi (#1285)
- Whirlpool: Change default mode in `convertMode()` (#1283 #1284)
- SamsungAC: Unit tests to help debug poor signal (#1277 #1280)
- Add question & note about VS1838b use to issue template. (#1281)
- rewrite ir_Corona (#1274)
- tools/mkkeywords: Fix minor parsing issue. (#1272)
- Add Zhongxian Li to Contributers.md (#1270)
- rewrite Carrier (#1269)
- rewrite ir_Argo by using bit field (#1264)
- rewrite ir_Amcor by using bit field (#1263)
- Update Fujitsu supported model info.
- Clarify the scope of the LittleFS breaking change.
@crankyoldgit crankyoldgit mentioned this pull request Oct 2, 2020
Merged
siriuslzx pushed a commit that referenced this pull request Oct 4, 2020
@crankyoldgit
v2.7.11 release (#1286)
922a104 
* Regenerate Doxygen documentation

* v2.7.11 release
_v2.7.11 (20201002)_

**[Features]**
- Transcold: Add detailed support. (#1256 #1278)
- Airwell/Whirlpool: Add handling of previous state to `.toCommon()` (#1275 #1276)
- IRMQTTServer: Change how MQTT packet/buffer size is set. (#1271)
- Fujitsu: Add support for timers. (#1255 #1261 #1262)
- Neoclima: Add Economy & Fahrenheit support (#1260 #1265)
- Technibel: Cleanup and code fixes/improvements. (#1259 #1266)
- Technibel: Add detailed A/C support (#1259)
- Transcold: Add basic support. (#1256 #1258)

**[Misc]**
- refactor ir_Delonghi (#1285)
- Whirlpool: Change default mode in `convertMode()` (#1283 #1284)
- SamsungAC: Unit tests to help debug poor signal (#1277 #1280)
- Add question & note about VS1838b use to issue template. (#1281)
- rewrite ir_Corona (#1274)
- tools/mkkeywords: Fix minor parsing issue. (#1272)
- Add Zhongxian Li to Contributers.md (#1270)
- rewrite Carrier (#1269)
- rewrite ir_Argo by using bit field (#1264)
- rewrite ir_Amcor by using bit field (#1263)
- Update Fujitsu supported model info.
- Clarify the scope of the LittleFS breaking change.
@crankyoldgit
Copy link
Owner

FYI, the changes mentioned above have now been included in the new v2.7.11 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crankyoldgit crankyoldgit crankyoldgit approved these changes

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siriuslzx @crankyoldgit @NiKiZe