Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory fragementation cause by String. #1536

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Reduce memory fragementation cause by String. #1536

merged 2 commits into from
Jul 21, 2021

Conversation

crankyoldgit
Copy link
Owner

  • Use more .reserve() to reduce fragmentation.
  • Calculate some reservation values more accurately rather than flat guesses.

For #1493

@crankyoldgit
Reduce memory fragementation cause by String.
14e0e42 
* Use more `.reserve()` to reduce fragmentation.
* Calculate some reservation values more accurately rather than flat guesses.

For #1493
@crankyoldgit crankyoldgit self-assigned this Jul 18, 2021
@crankyoldgit crankyoldgit requested a review from NiKiZe July 18, 2021 06:10
NiKiZe
NiKiZe approved these changes Jul 18, 2021
View reviewed changes
Copy link
Collaborator

@NiKiZe NiKiZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many magic numbers, some more explanation could be good
what is 55, 7, 28, 4, 93
19 + 11

Any chance some kind of tracing exists that could be used to detect if fragmentation happens, especially when running the tests?

@crankyoldgit
Copy link
Owner Author

crankyoldgit commented Jul 18, 2021 •
edited
Loading

Many magic numbers, some more explanation could be good
what is 55, 7, 28, 4, 93
19 + 11

Sure, I'll add some comments.
Basically, it's me counting the chars that are or could be used when creating the string.

Any chance some kind of tracing exists that could be used to detect if fragmentation happens, especially when running the tests?

I'm unaware of a tool that does this. These are all just semi-educated guesses on my part. I have no proof at all it even helps. :-/

@crankyoldgit
Turn string reservations
a6b4e1b 
* Add comments explaining magic values, per code review feedback.
* Fine tune magic values. ;-)
@crankyoldgit
Copy link
Owner Author

Many magic numbers, some more explanation could be good
what is 55, 7, 28, 4, 93
19 + 11

Sure, I'll add some comments.
Basically, it's me counting the chars that are or could be used when creating the string.

Any chance some kind of tracing exists that could be used to detect if fragmentation happens, especially when running the tests?

I'm unaware of a tool that does this. These are all just semi-educated guesses on my part. I have no proof at all it even helps. :-/

Done.

@crankyoldgit crankyoldgit merged commit 4a9a36d into master Jul 21, 2021
@crankyoldgit crankyoldgit deleted the reduce_string_frag branch July 28, 2021 08:24
crankyoldgit added a commit that referenced this pull request Aug 14, 2021
@crankyoldgit
Trotec3550: Add Fahrenheit support
59ef809 
* Add proper support for DegC and DegF
* Update `sendTrotec3550()` to STABLE.

For #1536
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release
1fbac6c 
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
@crankyoldgit crankyoldgit mentioned this pull request Aug 28, 2021
Merged
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release
e8dee1a 
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release (#1582)
21e7dd4 
## _v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

@jamsinclair jamsinclair Awaiting requested review from jamsinclair

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @NiKiZe