Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embed attestation can lookup chalk keys in multiple paths #445

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Nov 11, 2024

Issue

chalk was not picking up existing key in CI

for example https://github.com/zaproxy/zaproxy/actions/runs/11739273654/job/32703450631

Description

Previously embed provider only looked up keys in a single location which by default was current working directly.
This is not desirable in CI as placing additional files in PWD can have other side-effects.
As such setup-chalk-action was placing the generated key relative to chalk binary however chalk was not able to lookup that key.

Testing

Try loading existing key in CI

Previously embed provider only looked up keys in a single location
which by default was current working directly.
This is not desirable in CI as placing additional files in PWD
can have other side-effects.
As such setup-chalk-action was placing the generated key relative
to chalk binary however chalk was not able to lookup that key.
@miki725 miki725 marked this pull request as ready for review November 11, 2024 16:27
@miki725 miki725 requested a review from viega as a code owner November 11, 2024 16:27
@miki725 miki725 merged commit 5f3b315 into main Nov 11, 2024
4 checks passed
@miki725 miki725 deleted the sc-3180 branch November 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants