fix: correct git report datetimes #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki725
force-pushed
the
git
branch
2 times, most recently
from
d3c3b11 to
78eeadd
Compare
miki725
changed the title
When git reports its timestamp, its localized with the provided offset and as chalk wasnt accounting for that, in some cases, commit timestamps would show up as future timestamps which is very confusing Now all timestamps are normalized with the provided offset. In addition all date reporting was changed to use consistent output format of ISO-8601.
Comment on lines
-270
to
+262
| result.setIfNeeded("DATETIME_WHEN_CHALKED", pack(getDateTime())) | ||
| result.setIfNeeded("DATE_CHALKED", startTime.utc.format(timesDateFormat)) | ||
| result.setIfNeeded("TIME_CHALKED", startTime.utc.format(timesTimeFormat)) | ||
| result.setIfNeeded("TZ_OFFSET_WHEN_CHALKED", startTime.utc.format(timesTzFormat)) | ||
| result.setIfNeeded("DATETIME_WHEN_CHALKED", startTime.utc.format(timesIso8601Format)) |
mbaltrusitis
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif necessaryIssue
In some cases commit dates show as in the future.
Description
When git reports its timestamp, its localized with the provided offset and as chalk wasnt accounting for that, in some cases, commit timestamps would show up as future timestamps which is very confusing
Now all timestamps are normalized with the provided offset.
In addition all date reporting was changed to use consistent output format of ISO-8601.
Testing