Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File path editing for FileChooser may result in a crash. #98

Closed
xavmag opened this issue Feb 2, 2021 · 5 comments
Closed

File path editing for FileChooser may result in a crash. #98

xavmag opened this issue Feb 2, 2021 · 5 comments
Labels
bug crash report Crash reports sent from a built-in issue constructor

Comments

@xavmag
Copy link

xavmag commented Feb 2, 2021

Application Log
Version: 4.10.0
OS: Windows 10 10.0 x86
JRE: 1.8.0_231 Oracle Corporation
GPU: GeForce MX150/PCIe/SSE2
OpenGL vendor: NVIDIA Corporation
OpenGL version: 4.6.0 NVIDIA 460.79
[ExtensionModuleRepositoryService] Cached data is outdated.
[ExtensionModuleRepositoryService] Requesting new data from remote server.
[ConfigurationController] Incremental fonts are disabled
[VisUI] Warning, using invalid libGDX version for VisUI 1.4.8.
You are using libGDX 1.9.11 but you need 1.9.12. This may cause unexpected problems and runtime exceptions.
[GlobalShortcutHandler] Parsing shortcut file: hotkeys_default.txt
[ExtensionModuleRepositoryService] Data was loaded from remote server.
[text-red]Exception occurred:[] There is no input files to perform packing
[text-red]Stack trace:[] 
java.lang.IllegalStateException: There is no input files to perform packing
	at com.crashinvaders.texturepackergui.controllers.packing.processors.DataValidationProcessor.processPackage(DataValidationProcessor.java:25)
	at com.crashinvaders.texturepackergui.utils.packprocessing.CompositePackProcessor.processPackage(CompositePackProcessor.java:20)
	at com.crashinvaders.texturepackergui.utils.packprocessing.PackProcessingManager.lambda$execute$0(PackProcessingManager.java:60)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

[text-red]Exception occurred:[] There is no input files to perform packing
[text-red]Stack trace:[] 
java.lang.IllegalStateException: There is no input files to perform packing
	at com.crashinvaders.texturepackergui.controllers.packing.processors.DataValidationProcessor.processPackage(DataValidationProcessor.java:25)
	at com.crashinvaders.texturepackergui.utils.packprocessing.CompositePackProcessor.processPackage(CompositePackProcessor.java:20)
	at com.crashinvaders.texturepackergui.utils.packprocessing.PackProcessingManager.lambda$execute$0(PackProcessingManager.java:60)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Packing is started
Packing............
Writing 2048x128: C:\projects\LibGDX\prototype\android\assets\grey.png
Packing is done
Total pack files size is 20468 bytes
1 pages
Total processing time: 0.38sec

Packing is started
Packing.........
Writing 512x256: C:\projects\LibGDX\prototype\android\assets\yellow.png
Packing is done
Total pack files size is 17187 bytes
1 pages
Total processing time: 0.10sec

Packing is started
Packing.........
Writing 512x256: C:\projects\LibGDX\prototype\android\assets\red.png
Packing is done
Total pack files size is 18149 bytes
1 pages
Total processing time: 0.10sec

Packing is started
Packing............
Writing 2048x128: C:\projects\LibGDX\prototype\android\assets\grey.png
Packing is done
Total pack files size is 20582 bytes
1 pages
Total processing time: 0.15sec

[text-red]Exception occurred:[] Output directory is not specified
[text-red]Stack trace:[] 
java.lang.IllegalStateException: Output directory is not specified
	at com.crashinvaders.texturepackergui.controllers.packing.processors.DataValidationProcessor.processPackage(DataValidationProcessor.java:22)
	at com.crashinvaders.texturepackergui.utils.packprocessing.CompositePackProcessor.processPackage(CompositePackProcessor.java:20)
	at com.crashinvaders.texturepackergui.utils.packprocessing.PackProcessingManager.lambda$execute$0(PackProcessingManager.java:60)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

java.lang.IllegalArgumentException: actor cannot be null.
	at com.badlogic.gdx.scenes.scene2d.ui.Table.getCell(Table.java:417)
	at com.kotcrab.vis.ui.widget.MenuItem.getImageCell(MenuItem.java:352)
	at com.kotcrab.vis.ui.widget.file.internal.AbstractSuggestionPopup.createMenuItem(AbstractSuggestionPopup.java:36)
	at com.kotcrab.vis.ui.widget.file.internal.DirsSuggestionPopup$1$1.run(DirsSuggestionPopup.java:88)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.loop(Lwjgl3Application.java:157)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.<init>(Lwjgl3Application.java:117)
	at com.crashinvaders.texturepackergui.desktop.ApplicationStarter.start(ApplicationStarter.java:56)
	at com.crashinvaders.texturepackergui.desktop.ApplicationStarter.main(ApplicationStarter.java:35)

How to produce the bug

  1. Create new atlas
  2. Open the browse window to choose the output directory
  3. Highlight all the text after the last backward slash in the path bar
  4. Press backspace
@xavmag xavmag added the crash report Crash reports sent from a built-in issue constructor label Feb 2, 2021
@metaphore
Copy link
Member

Nicely spotted, thanks a lot! I can reproduce it on my end.
Probably a bug in the VisUI FileChooser widget.
Let's see if @kotcrab is aware of this one (it's VisUI 1.4.8)?

@metaphore metaphore added the bug label Feb 2, 2021
@metaphore metaphore changed the title Crash report File path editing for FileChooser may result in a crash. Feb 2, 2021
@kotcrab
Copy link

kotcrab commented Feb 2, 2021

Thanks, looks like this is caused by this change libgdx/libgdx@f829dfc doesn't seem to be in the change log. Anyway, I'll fix it.

@metaphore
Copy link
Member

Thanks @kotcrab!

@kotcrab
Copy link

kotcrab commented Feb 2, 2021

Fixed in kotcrab/vis-ui@aa0184c. The libgdx change is okay, it really worked by accident before.

@metaphore metaphore mentioned this issue May 9, 2021
@metaphore
Copy link
Member

All good, should be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash report Crash reports sent from a built-in issue constructor
Projects
None yet
Development

No branches or pull requests

3 participants