Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): enable reactivity of options via svelte action #108

Merged
merged 3 commits into from
May 29, 2023
Merged

feat(svelte): enable reactivity of options via svelte action #108

merged 3 commits into from
May 29, 2023

Conversation

kelvinsjk
Copy link
Contributor

Checklist

Changes

  • In order to allow for reactivity of the options object, we used a Svelte action to call the updateOptions method any time the options object is changed
  • Since the Svelte action directive also supports onMount and onDestroy, have refactored the original onMount and onDestroy code into the Svelte action
  • Added a condensed extract of the svelte example in the examples sub-folder into the README document to make it easier for someone installing from npm to immediately get going

@crashmax-dev crashmax-dev added the enhancement New feature or request label May 29, 2023
@crashmax-dev
Copy link
Owner

LGTM

@crashmax-dev crashmax-dev merged commit 874c105 into crashmax-dev:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants