We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend-exclude
Upgrading from v1.14.12 to v1.16.22 I'm encountering a typo detected in a file which should be excluded.
v1.14.12
v1.16.22
With the configuration:
[files] extend-exclude = ["resources", "snapshots"]
The file crates/ruff_python_formatter/src/comments/snapshots/ruff_python_formatter__comments__tests__match_cases.snap has a fixed typo.
crates/ruff_python_formatter/src/comments/snapshots/ruff_python_formatter__comments__tests__match_cases.snap
You can reproduce this with pre-commit run --all-files in https://github.com/astral-sh/ruff with the bumped version.
pre-commit run --all-files
Changing to "**/snapshots/**/*" resolves this.
"**/snapshots/**/*"
Please let me know if you need more information or if this is expected. I can produce a smaller example if necessary.
The text was updated successfully, but these errors were encountered:
I'm assuming this was broken by #837 (had worried there was a corner case like this). I have a local reproduction case.
The odd thing is that I would assume the exclude key in your pre-commit hook would prevent this from being hit.
exclude
Sorry, something went wrong.
fix(cli): Respect force-exclude for simple exclude pattersn
e24c694
Fixes crate-ci#868
Thanks for the fast fix. Gosh who knows what's up with the pre-commit hook exclude, guess that's the next thing to investigate.
pre-commit
Successfully merging a pull request may close this issue.
Upgrading from
v1.14.12
tov1.16.22
I'm encountering a typo detected in a file which should be excluded.With the configuration:
The file
crates/ruff_python_formatter/src/comments/snapshots/ruff_python_formatter__comments__tests__match_cases.snap
has a fixed typo.You can reproduce this with
pre-commit run --all-files
in https://github.com/astral-sh/ruff with the bumped version.Changing to
"**/snapshots/**/*"
resolves this.Please let me know if you need more information or if this is expected. I can produce a smaller example if necessary.
The text was updated successfully, but these errors were encountered: