Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "deffer" to typo list #535

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Add "deffer" to typo list #535

merged 1 commit into from
Aug 16, 2022

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Aug 16, 2022

No description provided.

@jplatte
Copy link
Contributor Author

jplatte commented Aug 16, 2022

I tried to fix the codegen thing with SNAPSHOTS=overwrite cargo test --workspace and then with SNAPSHOTS=overwrite cargo test -p typos-dict --test codegen, but it doesn't do anything except run a few tests successfully.

The error seen in the CI job also doesn't happen locally.

@epage
Copy link
Collaborator

epage commented Aug 16, 2022

I tried to fix the codegen thing with SNAPSHOTS=overwrite cargo test --workspace and then with SNAPSHOTS=overwrite cargo test -p typos-dict --test codegen, but it doesn't do anything except run a few tests successfully.

The error seen in the CI job also doesn't happen locally.

Strange, I just checked out your branch and ran cargo test -p typos-dict --test codegen and I had a test failure. I then ran SNAPSHOTS=overwrite cargo test -p typos-dict --test codegen and it succeeded by modifying the source file.

@jplatte
Copy link
Contributor Author

jplatte commented Aug 16, 2022

This is what I get:

% cargo test -p typos-dict --test codegen
    Finished test [unoptimized + debuginfo] target(s) in 0.04s
     Running tests/codegen.rs (target/debug/deps/codegen-2710dece8aac08d5)

running 1 test
test codegen ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 3.94s

@jplatte
Copy link
Contributor Author

jplatte commented Aug 16, 2022

I did a cargo clean and re-ran, it succeeded again but overwrote that one Rust file this time (even without SNAPSHOTS being set).

@epage
Copy link
Collaborator

epage commented Aug 16, 2022

I did a cargo clean and re-ran, it succeeded again but overwrote that one Rust file this time (even without SNAPSHOTS being set).

We use include_bytes!. I suspect there is a cargo bug in here with detecting rebuilds. I might try to go and reproduce this.

However, overwriting without SNAPSHOTS should not happen. All file writing is done via snapshot testing using snapbox which is being heavily used in several of my crates. I can't see why this would write when you didn't ask for it which is what worries me.

@epage epage merged commit bd75b23 into crate-ci:master Aug 16, 2022
@jplatte jplatte deleted the deffer branch August 16, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants