feat(cli): '--lsp' flag to start a basic LSP server #710
Conversation
|
This is my first real contribution in Rust, so I'm open to suggestions on best practice here. |
| @@ -0,0 +1,2 @@ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Good catch, this was lingering around from a refactor and can be removed.
| /// Start the LSP server. | ||
| #[arg(long, group = "mode")] | ||
| pub(crate) lsp: bool, |
There was a problem hiding this comment.
In seeing this come in and thinking through this more, I'm not sure I want to take this on.
If nothing else, this is taking on a new technology stack that I'm not very familiar with (I don't even use LSPs myself) and I do not have the available focus to come up to speed on it at this time. This means I don't have the background to review this, to make sure this approach aligns well with the relevant technologies, and then to maintain this going forward. For this to be "community maintained", it would need to be distinct enough to make clear that this has a different compatibility and support level. I've been doing some of that in clap and my experience with it hasn't been great.
There was a problem hiding this comment.
No problem, and thanks for taking a look at this. At this initial point, the support offered would realistically just be me. Given that, would a typos-lsp crate within this repo provide enough of a distinction, or better to leave this out of this repo altogether? If the later, I'll probably end up moving this into tekumara/typos-vscode and may suggest small successive PRs as needed to make the integration work 🙏 I'll happily work with either option.
There was a problem hiding this comment.
Thank you for being understanding!
Let's start outside the repo so I can better observe how all of this works before integrating it into my processes.
Adds the
--lspflag which starts a basic LSP server running on stdin/out.The initial capabilities of the server are minimal. It only provides diagnostics to identify typos.
Future PRs will include code actions (ie: quick fixes) and support for config files.
Resolves #263