Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shuould and repressented misspellings #906

Closed
wants to merge 1 commit into from

Conversation

Crown0815
Copy link

No description provided.

@epage
Copy link
Collaborator

epage commented Jan 12, 2024

Just wanted to check-in if there was a reason you are needing this now rather than adding it to #897 to be added and released in bulk at the end of the month?

@Crown0815
Copy link
Author

Hi @epage,
No particular reason. I assumed a PR is better than adding them to the ticket, then you have less work with it.
would it be better to add them to #897?

@epage
Copy link
Collaborator

epage commented Jan 12, 2024

The intention of #897 is to lower the amount of work for everyone. One quick update and release is easier on my side and its much easier for users to post the result.

@Crown0815
Copy link
Author

Understood.
Since it is not urgent on my side, shall I close this PR and add the typos to #897 then?

@epage
Copy link
Collaborator

epage commented Jan 15, 2024

Go ahead and put it there for now.

@epage epage closed this Jan 15, 2024
@Crown0815 Crown0815 deleted the patch-1 branch January 16, 2024 18:46
@Crown0815
Copy link
Author

@epage, thank you for your help.
I must say, typos is an amazing piece of software. The idea of going with predefined fixes for common typos and thereby reducing the chance of false corrections is great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants