Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: separate free-threaded and standard 3.13 distribution builds #111

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

RobPasMue
Copy link
Contributor

Closes #110

This separates the 3.13 standard and free-threaded Python versions for Windows, into 2 different stages. It seems like Windows systems are not handling properly having both 3.13 installations. Ideally we should be able to put them all in the same job but it seems that, in that case, the 3.13 Python versions collide and only one of them is recognized by the system.

This only happens on Windows.

@RobPasMue
Copy link
Contributor Author

RobPasMue commented Dec 3, 2024

Looks like there is some discussion going on in Quansight-Labs/setup-python#5 but, while we wait for a final decision, I would merge this PR and do a post release (or even patch release) to upload all distributions. Once a solution is raised I can come back and align this repo =)

@ngoldbaum
Copy link
Contributor

Looks like there is some discussion going on in Quansight-Labs/setup-python#5 but, while we wait for a final decision, I would merge this PR and do a post release (or even patch release) to upload all distributions. Once a solution is raised I can come back and align this repo =)

I agree, duplicating this is the correct thing to do until the upstream fix. Thanks for debugging and sending in a PR!

It seems like it's more common in the pyo3/maturin ecosystem than in scientific python to do all the builds in one CI job, so this wasn't caught until we started to work in this ecosystem.

@Julian Julian merged commit 8baaf22 into crate-py:main Dec 3, 2024
38 checks passed
@Julian
Copy link
Member

Julian commented Dec 3, 2024

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.13 wheels (non free-threaded) are not available
3 participants