[DRAFT] Update to ActiveRecord 5

.github/workflows/tests.yml

@@ -59,4 +59,4 @@ jobs:
           bundle install
 
       - name: Run tests
-        run: bundle exec rspec
+        run: bundle exec rspec --backtrace

DEVELOP.md

@@ -10,7 +10,7 @@ docker run --rm -it --publish=44200:4200 crate:5.1.1 \
 Install project and invoke test suite.
 ```shell
 bundle install
-bundle exec rspec
+bundle exec rspec --backtrace
 ```
 
 

activerecord-crate-adapter.gemspec

@@ -48,7 +48,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 2.14"
 
-  spec.add_dependency('activerecord', '~> 4.1.0')
+  spec.add_dependency('activerecord', '~> 5')
   spec.add_dependency('arel', '>= 5.0.0')
   spec.add_dependency('crate_ruby', '~> 0.2.0')
 end

lib/active_record/connection_adapters/crate_adapter.rb

@@ -23,7 +23,7 @@
 require 'active_record/base'
 require 'active_record/base'
 require 'arel/arel_crate'
-require 'arel/visitors/bind_visitor'
+require 'arel/visitors/visitor'
 require 'active_support/dependencies/autoload'
 require 'active_support/callbacks'
 require 'active_support/core_ext/string'
@@ -77,7 +77,7 @@ def schema_creation # :nodoc:
       }
 
       class BindSubstitution < Arel::Visitors::Crate # :nodoc:
-        include Arel::Visitors::BindVisitor
+        include Arel::Visitors
       end
 
       def initialize(connection, logger, pool, config)

lib/arel/arel_crate.rb

@@ -21,4 +21,4 @@
 
 require 'arel'
 require 'arel/visitors/crate'
-require 'arel/visitors/bind_visitor'
+require 'arel/visitors/visitor'

lib/arel/visitors/crate.rb

@@ -37,5 +37,3 @@ class ToSql < Arel::Visitors::Visitor
     end
   end
 end
-
-Arel::Visitors::VISITORS['crate'] = Arel::Visitors::Crate