Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQL Query Console docs #66

Merged
merged 12 commits into from
Mar 19, 2024
Merged

Add SQL Query Console docs #66

merged 12 commits into from
Mar 19, 2024

Conversation

matkuliak
Copy link
Contributor

@matkuliak matkuliak commented Mar 15, 2024 •
edited
Loading

What's Inside

Documentation for the new feature "SQL Query Console"

Preview

https://crate-cloud--66.org.readthedocs.build/en/66/reference/overview.html#connecting-to-your-cluster

Highlights

  • Introduction of the feature
  • How to access the feature
  • Pic with an example query
  • Formatting options of output
  • History of queries explained

Checklist

@matkuliak matkuliak requested review from amotl and proddata March 15, 2024 01:58
proddata
proddata requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@proddata proddata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it simple and just call it "Query Console" or "Console"

matkuliak and others added 3 commits March 18, 2024 14:43
@matkuliak @proddata
Apply suggestions from code review
1a0f454 
Co-authored-by: Georg Traar <proddata@users.noreply.github.com>
@matkuliak
Merge branch 'main' into mm/sql-console
f7dd136
@matkuliak
Rename file
ae2b830
@amotl amotl mentioned this pull request Mar 18, 2024
Merged
2 tasks
amotl
amotl requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@amotl amotl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. We added a few suggestions about wording improvements. Feel free to use them or not, also strongly depending on feedback by @proddata, because we don't want to step on your toes too much. Thanks!

docs/reference/overview.md Show resolved Hide resolved
docs/reference/overview.md Outdated Show resolved Hide resolved
docs/reference/overview.md Show resolved Hide resolved
docs/reference/overview.md Outdated Show resolved Hide resolved
matkuliak and others added 2 commits March 18, 2024 15:15
@matkuliak
Reference rename
7014549
@matkuliak @amotl
Apply suggestions from code review
a8408aa 
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
@amotl amotl mentioned this pull request Mar 18, 2024
Open
matkuliak and others added 3 commits March 18, 2024 16:12
@matkuliak matkuliak merged commit 9e7b6c0 into main Mar 19, 2024
3 checks passed
@matkuliak matkuliak deleted the mm/sql-console branch March 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl requested changes

@proddata proddata proddata requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matkuliak @amotl @proddata