-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme: Update to crate-docs-theme==0.34.0.dev6 #79
Conversation
fca6bb1
to
530afaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets go
^^ @proddata can decide if he wants to merge it, or not. If yes, please do on your own behalf. Thanks! |
4476481
to
8506ae4
Compare
It certainly makes a difference, for example here. You have to decide if you want it or not.
Before/AfterA picture says... /cc @msbt, @matkuliak, @simonprickett, @karynzv, @hammerhead, @hlcianfagna, @proddata, @widmogrod |
- Uses beta version of next generation theme. - Increases toctree maxdepth to 4.
Hi again. It looks like both |
Thanks for merging! |
I just followed your orders :D |
About
This RTD build gives you the chance to preview and review the documentation, using a pre-release of the modernized crate-docs-theme, based on sphinx-basic-ng/Furo.
Note
Also increases toctree maxdepth to 4. That may be good, or not, or it doesn't matter at all. Before, it was 2. See crate/crate-docs-theme#515.
Preview
https://crate-cloud--79.org.readthedocs.build/en/79/
Thoughts
It doesn't look too bad. Thanks for your fixes, @msbt!
If you agree, and don't object a slight anomaly in appearance, because other projects are not using the modernized theme yet, you are free to merge it at your disposal.
If you can spot any flaws or other more serious regressions, or just little ones, please let us know about them!
References
sphinx-basic-ng
crate-docs-theme#390/cc @surister, @simonprickett, @kneth