Tables route styling #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncombe
requested review from
plaharanne,
tomach,
WalBeh,
Taliik,
juanpardo,
SStorm and
alexdametto
as code owners
joncombe
force-pushed
the
jc/tables-route-styling
branch
from
b4d62d0 to
9be72df
Compare
alexdametto
approved these changes
Jan 26, 2024
src/routes/Tables/TableDetail.tsx
Outdated
| ]; | ||
|
|
||
| if (createTableSQL) { | ||
| ``; |
src/routes/Tables/TableDetail.tsx
Outdated
Comment on lines
75
to
77
| render: (_: string, record: TableInfo) => { | ||
| return <span>{record.data_type.toUpperCase()}</span>; | ||
| }, |
There was a problem hiding this comment.
Suggested change
| render: (_: string, record: TableInfo) => { | |
| return <span>{record.data_type.toUpperCase()}</span>; | |
| }, | |
| render: (dataType: string) => { | |
| return <span>{dataType.toUpperCase()}</span>; | |
| }, |
joncombe
force-pushed
the
jc/tables-route-styling
branch
2 times, most recently
from
a96fd54 to
7e9c758
Compare
joncombe
force-pushed
the
jc/tables-route-styling
branch
from
7e9c758 to
6deeea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Polished the tables route to be more on brand. Responsive, with usage still possible on smaller devices.
Note: there are quite a few inline colors specified here. Will be happy to move these to the tailwind config if the team are happy with them.
Checklist
CHANGES.md.