Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.10 #690

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Update to Python 3.10 #690

merged 1 commit into from
Dec 16, 2024

Conversation

tomach
Copy link
Contributor

@tomach tomach commented Dec 13, 2024

Summary of changes

Thanks a lot for your work @amotl!
I cherry-picked your commit from GH-675 and updated mypy to a newer version - not the latest one though. I thought a gradual approach might be better to keep things smoother and tackle changes incrementally without adding too much all at once.
So I would leave GH-654 open for now and address it once we tackle the upgrade to Python 3.11. wdyt?

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/2314
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@tomach tomach changed the title Ta/python310 Update to Python 3.10 Dec 16, 2024
@tomach tomach marked this pull request as ready for review December 16, 2024 08:42
Copy link
Contributor

@plaharanne plaharanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I don't mind if @amotl gives his feedback too.

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every update helps. Thanks. In general, the gradual approach to keep things smoother dearly needs some more velocity, because newer versions of Python provide subtle but great advantages.

@tomach tomach merged commit 6212b21 into master Dec 16, 2024
5 checks passed
@tomach tomach deleted the ta/python310 branch December 16, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants