Table Loader: Add capability to load InfluxDB Line Protocol (ILP) files #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Dec 21, 2024
Comment on lines
-132
to
+136
| elif source_url_obj.scheme.startswith("influxdb"): | ||
| elif ( | ||
| source_url_obj.scheme.startswith("influxdb") | ||
| or resource.url.endswith(".lp") | ||
| or resource.url.endswith(".lp.gz") | ||
| ): |
There was a problem hiding this comment.
The feature has been there already, and only needed to be unlocked here by adjusting the dispatching, and adding software tests and documentation.
This was referenced Dec 21, 2024
hammerhead
reviewed
Dec 23, 2024
doc/io/influxdb/loader.md
Outdated
| @@ -52,6 +60,18 @@ ctk show table "testdrive.demo" | |||
| - More convenient table querying. | |||
| ::: | |||
|
|
|||
| ### Line protocol file (ILP) | |||
There was a problem hiding this comment.
Suggested change
| ### Line protocol file (ILP) | |
| ### InfluxDB Line protocol file (ILP) |
Just to make it clear to the uneducated reader what the I in ILP stands for.
hammerhead
approved these changes
Dec 23, 2024
Synopsis: ctk load table "file://influxdb-export.lp"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Improve the InfluxDB table loader adapter by directly loading ILP files.
Synopsis
ctk load table "file://influxdb-export.lp"ctk load table \ "https://github.com/influxdata/influxdb2-sample-data/raw/master/air-sensor-data/air-sensor-data.lp"Documentation
Preview: https://cratedb-toolkit--333.org.readthedocs.build/io/influxdb/loader.html#line-protocol-file-ilp
References
History
influxio, implementingctk load table influxdb2://...#77if-existsquery parameter by updating to influxio 0.4.0 #176/cc @karynzv, @hlcianfagna, @hammerhead, @wierdvanderhaar, @surister, @simonprickett, @kneth