This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
change $arHeader['Content-type'] to array #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with $arHeader['Content-type'] = ''; become i this errors: PHP Warning: Illegal string offset 'type' in /lib/Cws/MailBounceHandler/Handler.php on line 915 PHP Warning: Illegal string offset 'report-type' in /lib/Cws/MailBounceHandler/Handler.php on line 918 PHP Warning: Illegal string offset 'boundary' in /lib/Cws/MailBounceHandler/Handler.php on line 918 PHP Warning: Illegal string offset 'type' in /lib/Cws/MailBounceHandler/Handler.php on line 1111 PHP Notice: Undefined index: first in /lib/Cws/MailBounceHandler/Handler.php on line 589
crazy-max
reviewed
Mar 1, 2017
| @@ -911,7 +911,7 @@ private static function parseHeader($arHeader) | |||
|
|
|||
| if (isset($arHeader['Content-type'])) { | |||
| $ar_mr = explode(';', $arHeader['Content-type']); | |||
| $arHeader['Content-type'] = ''; | |||
| $arHeader['Content-type'] = []; | |||
There was a problem hiding this comment.
Hi,
Thanks for this PR but can you make a new commit by replacing [] with array() for backward compatibility
|
Hi, Are you on PHP 7.x ? |
|
PHP 7.1 |
|
i have changed to array() |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with $arHeader['Content-type'] = ''; become i this errors:
PHP Warning: Illegal string offset 'type' in /lib/Cws/MailBounceHandler/Handler.php on line 915
PHP Warning: Illegal string offset 'report-type' in /lib/Cws/MailBounceHandler/Handler.php on line 918
PHP Warning: Illegal string offset 'boundary' in /lib/Cws/MailBounceHandler/Handler.php on line 918
PHP Warning: Illegal string offset 'type' in /lib/Cws/MailBounceHandler/Handler.php on line 1111
PHP Notice: Undefined index: first in /lib/Cws/MailBounceHandler/Handler.php on line 589