Better iOS launch screen logic. #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portons
pushed a commit
to portons/react-native-splash-screen
that referenced
this pull request
Jan 16, 2019
|
Did you plan to merge this PR soon ? It's very useful when restarting an app for example. And thanks to @ccorcos ! |
nullablebool
approved these changes
Jul 31, 2019
|
Moved to a new PR #412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach blocked the main thread to extend the amount of time the storyboard was visible.
This new implementation simply creates the the view from your LaunchScreen.storyboard and displays it. This also allows you to call
showandhidedynamically (not just shown on startup).