Skip to content

Commit

Permalink
Stop: Warn for stopping the containers instead error out
Browse files Browse the repository at this point in the history
As of now if somehow crictl not able to stop all the containers
then we are erroring out and failed the stop command. With this
patch we just warn user in case it fails and carry on with vm
shutdown.
  • Loading branch information
praveenkumar committed Nov 15, 2021
1 parent 5e5edba commit 14ce2fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/crc/machine/stop.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func (client *client) Stop() (state.State, error) {
return state.Error, errors.Wrap(err, "Cannot load machine")
}
if err := stopAllContainers(host, client); err != nil {
return state.Error, err
logging.Warnf("Failed to stop all containers: %v\nProceeding with stop...", err)
}
logging.Info("Stopping the OpenShift cluster, this may take a few minutes...")
if err := host.Stop(); err != nil {
Expand Down

0 comments on commit 14ce2fc

Please sign in to comment.