macos: Improve TrayExecutablePath construction

The code is calling InstallPath() even on crc versions where it was not
set at build time. Since InstallPath() is printing a warning when this
occurs, it's better if we can avoid this.
This commit adds a fallback to set TrayExecutablePath to
`~/.crc/bin/CodeReady Containers` in such scenarios.

pkg/crc/constants/constants_darwin.go

@@ -12,7 +12,14 @@ const (
 )
 
 var (
-	TrayExecutablePath   = filepath.Clean(filepath.Join(version.InstallPath(), "..", "MacOS", "CodeReady Containers"))
 	TapSocketPath        = filepath.Join(CrcBaseDir, "tap.sock")
 	DaemonHTTPSocketPath = filepath.Join(CrcBaseDir, "crc-http.sock")
 )
+
+func TrayExecutablePath() string {
+	if version.IsInstaller() {
+		return filepath.Clean(filepath.Join(version.InstallPath(), "..", "MacOS", "CodeReady Containers"))
+	}
+	// Should not be reached, tray is only supported on installer builds
+	return filepath.Clean(filepath.Join(BinDir(), "CodeReady Containers"))
+}

pkg/crc/preflight/preflight_checks_tray_darwin.go

@@ -24,7 +24,7 @@ func getTrayConfig() (*launchd.AgentConfig, error) {
 
 	trayConfig := launchd.AgentConfig{
 		Label:          trayAgentLabel,
-		ExecutablePath: constants.TrayExecutablePath,
+		ExecutablePath: constants.TrayExecutablePath(),
 		StdOutFilePath: stdOutFilePathTray,
 	}