Skip to content

Commit

Permalink
CI windows tester identify provisioned machine with github action run id
Browse files Browse the repository at this point in the history
Previously the commit sha was used to store the infra state on an azure blob, this cause some issues when an action was cancel and re run,
with this change we use the run id to store the state and avoid wrong state, also we added a link to the action execution as a tag so it is
easy to track back the provisioned machine from the cloud provider

Signed-off-by: Adrian Riobo Lorenzo <ariobolo@redhat.com>
  • Loading branch information
adrianriobo authored and praveenkumar committed May 8, 2024
1 parent 9120f1f commit b316f6f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/windows-qe-tpl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ jobs:
quay.io/rhqp/qenvs:v0.6.3 azure \
windows create \
--project-name 'windows-desktop-${{ matrix.windows-version }}-${{ matrix.windows-featurepack }}-${{inputs.qe-type}}-${{inputs.preset}}' \
--backed-url azblob://crc-qenvs-state/${{ env.commit_sha }} \
--backed-url azblob://crc-qenvs-state/${{ github.repository }}-${{ github.run_id }} \
--conn-details-output '/workspace' \
--windows-version '${{matrix.windows-version}}' \
--windows-featurepack '${{matrix.windows-featurepack}}' \
--tags project=openshift-local,source=github,org=${{github.repository_owner}} \
--tags project=openshift-local,source=github,org=${{github.repository_owner}},run=https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} \
--spot
podman logs -f windows-create
Expand Down Expand Up @@ -221,5 +221,5 @@ jobs:
quay.io/rhqp/qenvs:v0.6.3 azure \
windows destroy \
--project-name 'windows-desktop-${{ matrix.windows-version }}-${{ matrix.windows-featurepack }}-${{inputs.qe-type}}-${{inputs.preset}}' \
--backed-url azblob://crc-qenvs-state/${{ env.commit_sha }}
--backed-url azblob://crc-qenvs-state/${{ github.repository }}-${{ github.run_id }}
podman logs -f windows-destroy

0 comments on commit b316f6f

Please sign in to comment.