Skip to content

Commit

Permalink
macos: pkg: Install to /usr/local/crc
Browse files Browse the repository at this point in the history
The package only installs 3 binaries, vfkit, admin-helper and crc, we
can install these to /usr/local/crc and symlink crc to /usr/local/bin.

If we keep installing crc.pkg to /Applications, macOS will show a
non-functional icon in that folder since the macOS GUI logic is
only available in the crc-tray package which was split from crc.pkg in
the previous commits.
  • Loading branch information
cfergeau authored and openshift-merge-robot committed Mar 15, 2023
1 parent 8cf7415 commit e2669fc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ OKD_VERSION ?= 4.12.0-0.okd-2023-02-18-033438
BUNDLE_EXTENSION = crcbundle
CRC_VERSION = 2.15.0
COMMIT_SHA=$(shell git rev-parse --short HEAD)
MACOS_INSTALL_PATH = /Applications/Red Hat OpenShift Local.app/Contents/Resources
MACOS_INSTALL_PATH = /usr/local/crc
CONTAINER_RUNTIME ?= podman

TOOLS_DIR := tools
Expand Down
2 changes: 1 addition & 1 deletion packaging/darwin/macos-pkg-build-and-sign.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function signAppBundle() {

crcRootDir="${BASEDIR}/root-crc"
trayRootDir="${BASEDIR}/root-crc-tray"
crcBinDir="${crcRootDir}/Applications/Red Hat OpenShift Local.app/Contents/Resources"
crcBinDir="${crcRootDir}/usr/local/crc"

version=$(cat "${BASEDIR}/VERSION")

Expand Down

0 comments on commit e2669fc

Please sign in to comment.