Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Allow progressbars to be hidden when not using a terminal #3550

Closed
gbraad opened this issue Mar 18, 2023 · 1 comment · Fixed by #3547
Closed

[Enhancement] Allow progressbars to be hidden when not using a terminal #3550

gbraad opened this issue Mar 18, 2023 · 1 comment · Fixed by #3547
Labels
kind/bug Something isn't working status/need triage

Comments

@gbraad
Copy link
Contributor

gbraad commented Mar 18, 2023

This is a follow-up to #3547 to allow the progressbars to be hidden when no terminal is used. This is for the case when a redirection to a file is used.
@gbraad gbraad added kind/bug Something isn't working status/need triage labels Mar 18, 2023
@gbraad
Copy link
Contributor Author

gbraad commented Mar 18, 2023 •
edited
Loading

I personally do not favor this as it adds unnecessary complexity and the requirement to add a flag to allow an override to show the progressbars.

For example, changes are needed for the downloading path: #3547 (comment) and a possible introduction of a --show-progressbars to force them to be shown.

This was referenced Mar 18, 2023
Merged
Closed
gbraad added a commit to gbraad-redhat/crc that referenced this issue Mar 20, 2023
@gbraad
Fixes crc-org#3546 crc-org#3550 always show progress during uncompres…
9bcf42c 
…sion of the bundle

As part of `crc setup` we show the progress of the download and
uncompression. However, the download progress is always shown, while
the uncompression is suppressed when this is not a standard terninal.
For consistency we remove the suppression and add additional complexity
to allow this to be forced.
gbraad added a commit to gbraad-redhat/crc that referenced this issue Mar 20, 2023
@gbraad
Fixes crc-org#3546 crc-org#3550 always show progress during uncompres…
0384b0f 
…sion of the bundle

As part of `crc setup` we show the progress of the download and
uncompression. However, the download progress is always shown, while
the uncompression is suppressed when this is not a standard terninal.
For consistency we remove the suppression and add additional complexity
to allow this to be forced.
@gbraad gbraad linked a pull request Mar 20, 2023 that will close this issue
Fixes #3546 #3550 Add option to allow progressbars to be forced during download and uncompression of the bundle (setup phase) #3547
Merged
gbraad added a commit to gbraad-redhat/crc that referenced this issue Mar 20, 2023
@gbraad
Fixes crc-org#3546 crc-org#3550 always show progress during uncompres…
1c13250 
…sion of the bundle

As part of `crc setup` we show the progress of the download and
uncompression. However, the download progress is always shown, while
the uncompression is suppressed when this is not a standard terninal.
For consistency we remove the suppression and add additional complexity
to allow this to be forced.
gbraad added a commit to gbraad-redhat/crc that referenced this issue Mar 20, 2023
@gbraad
Fixes crc-org#3546 crc-org#3550 always show progress during uncompres…
1d67541 
…sion of the bundle

As part of `crc setup` we show the progress of the download and
uncompression. However, the download progress is always shown, while
the uncompression is suppressed when this is not a standard terninal.
For consistency we remove the suppression and add additional complexity
to allow this to be forced.
gbraad added a commit to gbraad-redhat/crc that referenced this issue Mar 20, 2023
@gbraad
Fixes crc-org#3546 crc-org#3550 always show progress during uncompres…
fb84ee0 
…sion of the bundle

As part of `crc setup` we show the progress of the download and
uncompression. However, the download progress is always shown, while
the uncompression is suppressed when this is not a standard terninal.
For consistency we remove the suppression and add additional complexity
to allow this to be forced.
openshift-merge-robot pushed a commit that referenced this issue Mar 20, 2023
@gbraad @openshift-merge-robot
Fixes #3546 #3550 always show progress during uncompression of the bu…
8296a0e 
…ndle

As part of `crc setup` we show the progress of the download and
uncompression. However, the download progress is always shown, while
the uncompression is suppressed when this is not a standard terninal.
For consistency we remove the suppression and add additional complexity
to allow this to be forced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working status/need triage
Projects
None yet
Milestone
No milestone
1 participant
@gbraad