Integration: Add checks for the initial start of the VM with custom values (memory, cpus, disk) #3536
Conversation
|
@jsliacan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| }) | ||
|
|
||
| It("check VM's memory size", func() { | ||
| out, err := SendCommandToVM("cat /proc/meminfo") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(out).Should(MatchRegexp(`MemTotal:[\s]*9\d{6}`)) | ||
| Expect(out).Should(MatchRegexp(`MemTotal:[\s]*11\d{6}`)) | ||
| }) | ||
|
|
||
| It("check VM's number of cpus", func() { | ||
| out, err := SendCommandToVM("cat /proc/cpuinfo") |
There was a problem hiding this comment.
not a blocker but just a suggestion , why are we not using lscpu and then use CPU\(s\):[\s]*5 which provide us correct cpus instead one less because /proc/cpuinfo start it from 0? May be another PR to try and fix it?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Re: Issue #3496 and solution in #3511. Also, serves the same purpose as the check in
basic.featurein e2e as asked for in #3518.Replacing default values in initial start by custom values and corresponding checks. The test already exists as integration test
resize_test.go, so I just tweaked that one. I used this occasion to do the same formemoryandcpusparameters.