go.mod: Update gvisor_vsock_tap dependency #3703
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| github.com/ProtonMail/go-crypto v0.0.0-20230217124315-7d5c6f04bbb8 | ||
| github.com/YourFin/binappend v0.0.0-20181105185800-0add4bf0b9ad | ||
| github.com/asaskevich/govalidator v0.0.0-20210307081110-f21760c49a8d | ||
| github.com/cavaliergopher/grab/v3 v3.0.1 | ||
| github.com/cheggaaa/pb/v3 v3.1.0 | ||
| github.com/containers/gvisor-tap-vsock v0.5.0 | ||
| github.com/containers/gvisor-tap-vsock v0.6.2-0.20230609094134-b79db04d368e |
There was a problem hiding this comment.
I'd prefer to stick to release gvisor-tap-vsock versions.
There was a problem hiding this comment.
@cfergeau once we have the next release cut we will use it but as of now we have a old release.
There was a problem hiding this comment.
this fixes a critical bug on CRC, it'd be good to vendor a released gvisor-tap-vscok but since we don't have a newer release with the needed changes, we can do that when there's new release for gvisor-tap-vsock
There was a problem hiding this comment.
Since we are the upstream for gvisor-tap-vsock, getting a new release is relatively easy... ;)
|
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
praveenkumar
added
the
has-to-be-in-release
Updating to containers/gvisor-tap-vsock@b79db04 which resolve crc-org#3643 issue.
praveenkumar
force-pushed
the
update_gvisor_vsock
branch
from
215c0ac
to
a8a4e3e
Compare
|
@praveenkumar , is there a patch I can use or do I need to wait for the next release of crc? Thanks for fixing this. |
|
@mmurhamm |
Updating to containers/gvisor-tap-vsock@b79db04 which resolve #3643 issue.
Fixes: Issue #3643