test: microshift: Don't force network-mode to 'user' #3804
Conversation
We want our testing to be as close as possible to what end-users will experience. Changing `network-mode` is a significant difference from the default. With crc-org/snc#797 fixed, we no longer need to force it to `user`.
…latform" This reverts commit 557ec94. We no longer set network-mode as part of the tests, so this code is not needed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
@cfergeau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jsliacan Can you try that and see if that works as expected. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Filing this now so that we don't forget it when we have bundles with crc-org/snc#797. This will be put on hold until this happens.
We want our testing to be as close as possible to what end-users will
experience. Changing
network-modeis a significant difference from thedefault. With crc-org/snc#797 fixed, we no longer
need to force it to
user.