Update DEST_DIR_SUFFIX in case of pr #982
Conversation
|
/cherry-pick release-4.18 |
|
@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.17 |
|
@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.16 |
|
@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
Recently on crc side[0] we have enabled the regex to capture bundle info and as part of this regex we are capturing the custom bundle which is random generated number like `crc_okd_vfkit_4.16.7_amd64_2342465234654.crcbundle` but for bundles generated by the pr have suffix `.pr<pr_number>` which means again adjust the regex. We can still identify the bundle with `_<pr_number>` and this way we don't need to update the regex. - crc-org/crc#4343
praveenkumar
force-pushed
the
fix_pr_number
branch
from
72636da
to
7be790f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath, cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@praveenkumar: new pull request created: #983 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@praveenkumar: new pull request created: #984 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@praveenkumar: new pull request created: #985 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Recently on crc side[0] we have enabled the regex to capture bundle info and as part of this regex we are capturing the custom bundle which is random generated number like
crc_okd_vfkit_4.16.7_amd64_2342465234654.crcbundlebut for bundles generated by the pr have suffix.pr<pr_number>which means again adjust the regex. We can still identify the bundle with_<pr_number>and this way we don't need to update the regex.