Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookup of underenhet by org number #11

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Add lookup of underenhet by org number #11

merged 4 commits into from
Nov 16, 2023

Conversation

jodal
Copy link
Member

@jodal jodal commented Nov 16, 2023

  • Drop fixtures for loading mock responses
  • Make room for get_underenhet()
  • Extract error handling from client methods
  • Add get_underenheter() method

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fde80f7) 92.59% compared to head (9cf1dd6) 92.95%.

Files Patch % Lines
src/brreg/enhetsregisteret/_client.py 75.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   92.59%   92.95%   +0.36%     
==========================================
  Files           5        5              
  Lines         108      142      +34     
  Branches        4        8       +4     
==========================================
+ Hits          100      132      +32     
- Misses          6        7       +1     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jodal jodal merged commit 5d7a6c3 into main Nov 16, 2023
5 checks passed
@jodal jodal deleted the underenhet branch November 16, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants