Fix failing GitHub Actions #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
reviewed
Jan 25, 2025
There was a problem hiding this comment.
Ah thanks, this suggests the error I'm seeing is mostly just misleading -- it's not really a missing symbol so much as an entirely-missing library 🤦🏻♀️
Probably before merging this, I should revert some of the flailing about I did in the meanwhile. Will do that, then perhaps we can update this.
| if: runner.os == 'macOS' | ||
| run: brew install gmp | ||
| - name: make check # unit and compatibility tests | ||
| if: matrix.compiler == 'clang' |
There was a problem hiding this comment.
This is fine but shouldn't be necessary, since the matrix already excludes gcc for macos.
|
Closing in favor of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- name: "macOS: brew install gmp" if: runner.os == 'macOS' run: brew install gmphttps://formulae.brew.sh/formula/gmp
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
macOS: