Add a barrier constraining execution order for notifications. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When issuing a batch of requests, keep track of the number that are valid notifications, and do not issue to any handler for the batch until all notifications received in previous batches have completed. This ensures a sensible partial order on notifications. Multiple notifications in a single batch can still be executed in parallel, but notifications across batches are no longer concurrent. Update tests and documentation.
|
Checks are still not triggering. Possibly https://www.githubstatus.com/incidents/phnch1rww464 is related; I'll check back later. |
This was referenced Aug 13, 2020
creachadair
added a commit
that referenced
this pull request
Aug 13, 2020
Fixes #27. Since #24, the server holds its lock during dispatch to wait for previously-issued notifications to settle. This is necessary to ensure a sensible order of operations; however, it interacts badly with a notification handler that uses the jrpc2.CancelRequest helper: That function itself acquires the server lock, and the two (may) deadlock. To avert this problem, wait on the notification barrier outside the lock. Add a regression test against the original bug.
creachadair
added a commit
that referenced
this pull request
Aug 14, 2020
Fixes #27. Since #24, the server holds its lock during dispatch to wait for previously-issued notifications to settle. This is necessary to ensure a sensible order of operations; however, it interacts badly with a notification handler that uses the jrpc2.CancelRequest helper: That function itself acquires the server lock, and the two (may) deadlock. To avert this problem, wait on the notification barrier outside the lock. Add a regression test against the original bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to address #20.
When issuing a batch of requests, keep track of the number that are valid notifications, and do not issue to any handler for the batch until all notifications received in previous batches have completed.
This ensures a sensible partial order on notifications. Multiple notifications in a single batch can still be executed in parallel, but notifications across batches are no longer concurrent.
Before merging: